[cfe-commits] Patch to save category name loc in ObjCCategoryImplDecl

[Jason Haslam]

On Dec 8, 2011, at 12:27 PM, jahanian wrote:

> On Dec 8, 2011, at 11:14 AM, Jason Haslam wrote:
> 
>> Hmm… okay. I guess that the only justification that I have is that we use it in our IDE to point to the location of the category implementation (e.g. when the user right clicks on the category name in the interface declaration and selects 'Edit Implementation'). There's no other use in clang itself.
> We have couple of locations you may use:
> 
> ObjCCategoryImplDecl(DeclContext *DC, IdentifierInfo *Id,
>                        ObjCInterfaceDecl *classInterface,
>                        SourceLocation nameLoc, SourceLocation atStartLoc)
> 

Yes, I noticed those. We like to select the name of the referenced entity when we jump to its location. And deriving the location of the category name from the location of the class name seemed too error prone and complicated, especially given that it's already known at the point where the node is constructed. However, this is really too minor a point to argue about. If you don't feel that it adds any value that's good enough for me. Thanks for the review.

Jason

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20111208/8ad54faf/attachment.html>