<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div><br></div><div><br><div><div>On Dec 8, 2011, at 11:14 AM, Jason Haslam wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hmm… okay. I guess that the only justification that I have is that we use it in our IDE to point to the location of the category implementation (e.g. when the user right clicks on the category name in the interface declaration and selects 'Edit Implementation'). There's no other use in clang itself.<br></div></blockquote>We have couple of locations you may use:<div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">ObjCCategoryImplDecl(<span style="color: rgb(86, 129, 134); ">DeclContext</span> *DC, <span style="color: rgb(86, 129, 134); ">IdentifierInfo</span> *Id,</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span style="color: rgb(86, 129, 134); ">ObjCInterfaceDecl</span> *classInterface,</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; "> <span style="color: rgb(86, 129, 134); ">SourceLocation</span> nameLoc, <span style="color: rgb(86, 129, 134); ">SourceLocation</span> atStartLoc)</div><div><br></div><div>- Fariborz</div></div><div><br></div><blockquote type="cite"><div><br>Jason<br><br><br>On Dec 8, 2011, at 11:33 AM, jahanian wrote:<br><br><blockquote type="cite">We don't want to increase size of AST nodes unless there is justification for it.<br></blockquote><blockquote type="cite">Please provide the completed patch showing what it is used for.<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">- Fariborz<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">On Dec 8, 2011, at 9:34 AM, Jason Haslam wrote:<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite"><blockquote type="cite">This small patch saves the SourceLocation of the category name in ObjCCategoryImplDecl.<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">Jason<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><category_impl_name_loc.diff>_______________________________________________<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite">cfe-commits mailing list<br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="mailto:cfe-commits@cs.uiuc.edu">cfe-commits@cs.uiuc.edu</a><br></blockquote></blockquote><blockquote type="cite"><blockquote type="cite"><a href="http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits">http://lists.cs.uiuc.edu/mailman/listinfo/cfe-commits</a><br></blockquote></blockquote><blockquote type="cite"><br></blockquote><br></div></blockquote></div><br></div></div></body></html>