[cfe-commits] [PATCH] Add CMake dependencies so that LLVM_USED_LIBS order doesn't matter (issue4178045)

[Óscar Fuentes]

jyasskin at gmail.com writes:

> Description:
> chapuni asked me to split this out of
> http://codereview.appspot.com/4152043/. It's probably not the complete
> set of dependencies we need to add, but it makes the new unittest work.

[snip]

> Index: tools/driver/CMakeLists.txt
> ===================================================================
> --- tools/driver/CMakeLists.txt	(revision 125369)
> +++ tools/driver/CMakeLists.txt	(working copy)
> @@ -1,19 +1,19 @@
>   set( LLVM_USED_LIBS
> +  clangAST
> +  clangAnalysis
> +  clangBasic
> +  clangCodeGen
> +  clangDriver
> +  clangFrontend
>     clangFrontendTool
> -  clangFrontend
> -  clangDriver
> -  clangSerialization
> -  clangCodeGen
> +  clangIndex
> +  clangLex
>     clangParse
> +  clangRewrite
>     clangSema
> +  clangSerialization
>     clangStaticAnalyzerCheckers
>     clangStaticAnalyzerCore
> -  clangAnalysis
> -  clangIndex
> -  clangRewrite
> -  clangAST
> -  clangLex
> -  clangBasic
>     )

How listing the libraries in alphabetical order helps the unittests to
work?

Anyways, the patch is ok. Have you commit access?

[snip]