[cfe-commits] [PATCH] Add CMake dependencies so that LLVM_USED_LIBS order doesn't matter (issue4178045)
Jeffrey Yasskin
jyasskin at google.com
Fri Feb 11 15:47:35 PST 2011
On Fri, Feb 11, 2011 at 6:44 AM, Óscar Fuentes <ofv at wanadoo.es> wrote:
> jyasskin at gmail.com writes:
>
>> Description:
>> chapuni asked me to split this out of
>> http://codereview.appspot.com/4152043/. It's probably not the complete
>> set of dependencies we need to add, but it makes the new unittest work.
>
> [snip]
>
>> Index: tools/driver/CMakeLists.txt
>> ===================================================================
>> --- tools/driver/CMakeLists.txt (revision 125369)
>> +++ tools/driver/CMakeLists.txt (working copy)
>> @@ -1,19 +1,19 @@
>> set( LLVM_USED_LIBS
>> + clangAST
>> + clangAnalysis
>> + clangBasic
>> + clangCodeGen
>> + clangDriver
>> + clangFrontend
>> clangFrontendTool
>> - clangFrontend
>> - clangDriver
>> - clangSerialization
>> - clangCodeGen
>> + clangIndex
>> + clangLex
>> clangParse
>> + clangRewrite
>> clangSema
>> + clangSerialization
>> clangStaticAnalyzerCheckers
>> clangStaticAnalyzerCore
>> - clangAnalysis
>> - clangIndex
>> - clangRewrite
>> - clangAST
>> - clangLex
>> - clangBasic
>> )
>
> How listing the libraries in alphabetical order helps the unittests to
> work?
Alphabetizing here doesn't matter to the unittests. It makes it easier
to decide where to put a new library since you don't have to worry
that you're breaking someone else's notion of the correct order.
> Anyways, the patch is ok. Have you commit access?
Thanks! Yes, I'll commit.
More information about the cfe-commits
mailing list