[cfe-commits] [PATCH] Add CMake dependencies so that LLVM_USED_LIBS order doesn't matter (issue4178045)

jyasskin at gmail.com jyasskin at gmail.com
Fri Feb 11 00:47:19 PST 2011


Reviewers: cfe-commits_cs.uiuc.edu,

Message:
Initial patch at
http://codereview.appspot.com/download/issue4178045_1.diff

Description:
chapuni asked me to split this out of
http://codereview.appspot.com/4152043/. It's probably not the complete
set of dependencies we need to add, but it makes the new unittest work.

Please review this at http://codereview.appspot.com/4178045/

Affected files:
   M     lib/AST/CMakeLists.txt
   M     lib/Basic/CMakeLists.txt
   M     lib/CodeGen/CMakeLists.txt
   M     lib/Frontend/CMakeLists.txt
   M     lib/Lex/CMakeLists.txt
   M     lib/Serialization/CMakeLists.txt
   M     lib/StaticAnalyzer/Core/CMakeLists.txt
   M     tools/driver/CMakeLists.txt


Index: tools/driver/CMakeLists.txt
===================================================================
--- tools/driver/CMakeLists.txt	(revision 125369)
+++ tools/driver/CMakeLists.txt	(working copy)
@@ -1,19 +1,19 @@
  set( LLVM_USED_LIBS
+  clangAST
+  clangAnalysis
+  clangBasic
+  clangCodeGen
+  clangDriver
+  clangFrontend
    clangFrontendTool
-  clangFrontend
-  clangDriver
-  clangSerialization
-  clangCodeGen
+  clangIndex
+  clangLex
    clangParse
+  clangRewrite
    clangSema
+  clangSerialization
    clangStaticAnalyzerCheckers
    clangStaticAnalyzerCore
-  clangAnalysis
-  clangIndex
-  clangRewrite
-  clangAST
-  clangLex
-  clangBasic
    )

  set( LLVM_LINK_COMPONENTS
Index: lib/Frontend/CMakeLists.txt
===================================================================
--- lib/Frontend/CMakeLists.txt	(revision 125369)
+++ lib/Frontend/CMakeLists.txt	(working copy)
@@ -1,9 +1,10 @@
  set( LLVM_USED_LIBS
+  clangAST
    clangDriver
+  clangLex
    clangParse
    clangSema
-  clangAST
-  clangLex
+  clangSerialization
    clangBasic
    )

Index: lib/Basic/CMakeLists.txt
===================================================================
--- lib/Basic/CMakeLists.txt	(revision 125369)
+++ lib/Basic/CMakeLists.txt	(working copy)
@@ -1,3 +1,5 @@
+set(LLVM_LINK_COMPONENTS mc)
+
  add_clang_library(clangBasic
    Builtins.cpp
    ConvertUTF.c
Index: lib/AST/CMakeLists.txt
===================================================================
--- lib/AST/CMakeLists.txt	(revision 125369)
+++ lib/AST/CMakeLists.txt	(working copy)
@@ -1,3 +1,5 @@
+set(LLVM_LINK_COMPONENTS support)
+
  set(LLVM_USED_LIBS clangBasic)

  add_clang_library(clangAST
Index: lib/Lex/CMakeLists.txt
===================================================================
--- lib/Lex/CMakeLists.txt	(revision 125369)
+++ lib/Lex/CMakeLists.txt	(working copy)
@@ -1,5 +1,7 @@
  # TODO: Add -maltivec when ARCH is PowerPC.

+set(LLVM_LINK_COMPONENTS support)
+
  set(LLVM_USED_LIBS clangBasic)

  add_clang_library(clangLex
Index: lib/StaticAnalyzer/Core/CMakeLists.txt
===================================================================
--- lib/StaticAnalyzer/Core/CMakeLists.txt	(revision 125369)
+++ lib/StaticAnalyzer/Core/CMakeLists.txt	(working copy)
@@ -1,3 +1,5 @@
+set(LLVM_LINK_COMPONENTS support)
+
  set(LLVM_USED_LIBS clangBasic clangLex clangAST clangFrontend clangRewrite)

  add_clang_library(clangStaticAnalyzerCore
Index: lib/CodeGen/CMakeLists.txt
===================================================================
--- lib/CodeGen/CMakeLists.txt	(revision 125369)
+++ lib/CodeGen/CMakeLists.txt	(working copy)
@@ -1,3 +1,10 @@
+set(LLVM_LINK_COMPONENTS
+  asmparser
+  bitreader
+  bitwriter
+  ipo
+  )
+
  set(LLVM_USED_LIBS clangBasic clangAST clangFrontend)

  add_clang_library(clangCodeGen
Index: lib/Serialization/CMakeLists.txt
===================================================================
--- lib/Serialization/CMakeLists.txt	(revision 125369)
+++ lib/Serialization/CMakeLists.txt	(working copy)
@@ -1,4 +1,5 @@
-set(LLVM_USED_LIBS clangFrontend)
+# TODO: This must need some dependencies, but it builds fine without them.
+#set(LLVM_USED_LIBS ???)

  add_clang_library(clangSerialization
    GeneratePCH.cpp





More information about the cfe-commits mailing list