[cfe-commits] [PATCH] test/Coverage/html-diagnostics.c: a potential bug and mingw-msys tweak

Douglas Gregor dgregor at apple.com
Mon Oct 18 07:51:50 PDT 2010


On Oct 17, 2010, at 9:26 PM, NAKAMURA Takumi wrote:

> Good afternoon.
> 
> 
> There are two issues for html-diagnostics.c.
> 
> * A potential bug: "CHECK: Dereference of null pointer" always succeeds.
> 
>  This expression always hits to the output itself in the comment.
> 
> <tr><td class="num" id="LN9">9</td><td class="line"><span
> class='comment'>// CHECK: Dereference of null pointer</span></td></tr>
> 
> * MSYS's cat(1) does not glob wildcards.
> 
>  find(1) could do alternatively. Toolchain gnuwin32 has find.exe, too.


This test is very messy. Thank you for improving it! Please commit.

	- Doug



More information about the cfe-commits mailing list