[cfe-commits] [PATCH] test/Coverage/html-diagnostics.c: a potential bug and mingw-msys tweak

NAKAMURA Takumi geek4civic at gmail.com
Mon Oct 18 20:48:37 PDT 2010


Applied in r116782 and r116793, thank you!

...Takumi

2010/10/18 Douglas Gregor <dgregor at apple.com>:
>
> On Oct 17, 2010, at 9:26 PM, NAKAMURA Takumi wrote:
>
>> Good afternoon.
>>
>>
>> There are two issues for html-diagnostics.c.
>>
>> * A potential bug: "CHECK: Dereference of null pointer" always succeeds.
>>
>>  This expression always hits to the output itself in the comment.
>>
>> <tr><td class="num" id="LN9">9</td><td class="line"><span
>> class='comment'>// CHECK: Dereference of null pointer</span></td></tr>
>>
>> * MSYS's cat(1) does not glob wildcards.
>>
>>  find(1) could do alternatively. Toolchain gnuwin32 has find.exe, too.
>
>
> This test is very messy. Thank you for improving it! Please commit.
>
>        - Doug
>




More information about the cfe-commits mailing list