[cfe-commits] [PATCH] Add Clang driver-support for directory-style precompiled headers

Douglas Gregor dgregor at apple.com
Mon Oct 18 14:28:47 PDT 2010

On Oct 15, 2010, at 12:04 PM, Tor Arne Vestbø wrote:

> On 15.10.10 20.57, Argyrios Kyrtzidis wrote:
>> This is less about supporting directory-style precompiled headers and
>> more about supporting Qt's build system.
> Well, yes and no. I've successfully compiled Qt with Clang using the 
> solution you outline, but I figured I'd give it a shot at fixing this 
> upstream so other people could benefit from it.
> If it's too hacky (as I admit, it does not do what GCC does, which is 
> actually parse each header found in the PCH directory and choose the 
> first matching one for the input language) I'm fine with that as well -- 
> as you say we have a solution for Qt.

Personally, I'd rather either implement what GCC does (looking through the PCH files to find one that works) or not implement this feature at all. Basing our choice on the naming of the PCH file feels brittle.

	- Doug

More information about the cfe-commits mailing list