[all-commits] [llvm/llvm-project] 742a06: [clang] Remove #undef alloca workaround (#81534)

Arthur Eubanks via All-commits all-commits at lists.llvm.org
Tue Feb 13 09:49:34 PST 2024


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 742a06f577b4c3b1c1f994e91bb6579ae89fe4b0
      https://github.com/llvm/llvm-project/commit/742a06f577b4c3b1c1f994e91bb6579ae89fe4b0
  Author: Arthur Eubanks <aeubanks at google.com>
  Date:   2024-02-13 (Tue, 13 Feb 2024)

  Changed paths:
    M clang/include/clang/Basic/Builtins.h

  Log Message:
  -----------
  [clang] Remove #undef alloca workaround (#81534)

Added in 26670dcba1609574cba5942aff78ff97b567c5f3 to workaround #4885.

Windows CI and a local Windows build are happy with this change, so it
seems like this has been properly fixed at some point. If this does
break somebody, this can be easily reverted. (Also, Linux does the same
`#define alloca` in system headers, so I'm not sure why it'd be
different on Windows)

This is tech debt that caused breakages, see comments on #71709.




More information about the All-commits mailing list