[all-commits] [llvm/llvm-project] fba457: [lit] Echo full RUN lines in case of external shel...

Joel E. Denny via All-commits all-commits at lists.llvm.org
Tue Sep 19 09:46:50 PDT 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: fba457d77e59bff91fe3e01dcaec6cf3d2b5b556
  Author: Joel E. Denny <jdenny.ornl at gmail.com>
  Date:   2023-09-19 (Tue, 19 Sep 2023)

  Changed paths:
    M llvm/utils/lit/lit/TestRunner.py
    A llvm/utils/lit/tests/Inputs/shtest-external-shell-kill/lit.cfg
    A llvm/utils/lit/tests/Inputs/shtest-external-shell-kill/test.txt
    A llvm/utils/lit/tests/Inputs/shtest-run-at-line/external-shell/empty-run-line.txt
    A llvm/utils/lit/tests/Inputs/shtest-run-at-line/internal-shell/empty-run-line.txt
    A llvm/utils/lit/tests/shtest-external-shell-kill.py
    M llvm/utils/lit/tests/shtest-run-at-line.py

  Log Message:
  [lit] Echo full RUN lines in case of external shells (#66408)

Before <https://reviews.llvm.org/D154984> and
<https://reviews.llvm.org/D156954>, lit reported full RUN lines in a
`Script:` section. Now, in the case of lit's internal shell, it's the
execution trace that includes them. However, if lit is configured to use
an external shell (e.g., bash, windows `cmd`), they aren't reported at

A fix was requested at the following:

* <https://reviews.llvm.org/D154984#4627605>

This patch does not address the case when the external shell is windows
`cmd`. As discussed at
<https://github.com/llvm/llvm-project/pull/65242>, it's not clear
whether that's a use case that people still care about, and it seems to
be generally broken anyway.

More information about the All-commits mailing list