[all-commits] [llvm/llvm-project] 06e1bc: [InlineAsm] break up Data Bitfield::Element into c...

Nick Desaulniers via All-commits all-commits at lists.llvm.org
Fri Sep 15 10:04:46 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 06e1bcaa1c0b330767540a415c6df799d772f6f1
      https://github.com/llvm/llvm-project/commit/06e1bcaa1c0b330767540a415c6df799d772f6f1
  Author: Nick Desaulniers <nickdesaulniers at users.noreply.github.com>
  Date:   2023-09-15 (Fri, 15 Sep 2023)

  Changed paths:
    M llvm/include/llvm/IR/InlineAsm.h

  Log Message:
  -----------
  [InlineAsm] break up Data Bitfield::Element into corresponding fields (#66297)

Use multiple Bitfield::Element's to provide more meaningful access to
the same slice of bits. "Data" used in different contexts is confusing.
Try to be as clear as possible, and in that vein, update the comment
block for this class, too.

This was suggested by @bwendling in
https://github.com/llvm/llvm-project/pull/65649#discussion_r1318962795
and @jyknight in

https://github.com/llvm/llvm-project/pull/65649#pullrequestreview-1620359094




More information about the All-commits mailing list