[all-commits] [llvm/llvm-project] 67ba29: [InstCombine] Add tests for transforming `(icmp pr...

goldsteinn via All-commits all-commits at lists.llvm.org
Wed Sep 13 13:50:50 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 67ba29380809d0e932acb2ff29690ad99e5c832c
      https://github.com/llvm/llvm-project/commit/67ba29380809d0e932acb2ff29690ad99e5c832c
  Author: Noah Goldstein <goldstein.w.n at gmail.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    A llvm/test/Transforms/InstCombine/icmp-of-and-x.ll

  Log Message:
  -----------
  [InstCombine] Add tests for transforming `(icmp pred (and X, Y), X)`; NFC

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D145424


  Commit: 119194ada6385f0a75a7e7e50915daab2841dc9f
      https://github.com/llvm/llvm-project/commit/119194ada6385f0a75a7e7e50915daab2841dc9f
  Author: Noah Goldstein <goldstein.w.n at gmail.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
    M llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-uge-to-icmp-ule.ll
    M llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ugt-to-icmp-ugt.ll
    M llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ule-to-icmp-ule.ll
    M llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-ult-to-icmp-ugt.ll
    M llvm/test/Transforms/InstCombine/icmp-of-and-x.ll

  Log Message:
  -----------
  [InstCombine] Transform `(icmp ult/uge (and X, Y), X)` -> `(icmp ne/eq (and X, Y), X)`

eq/ne are generally easier to reason about elsewhere.

ult -> ne: https://alive2.llvm.org/ce/z/5wxXGt
uge -> eq: https://alive2.llvm.org/ce/z/Dw6kqG

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D145425


  Commit: 2a904f456afa161a3cc9029375ed54ed1f808dd9
      https://github.com/llvm/llvm-project/commit/2a904f456afa161a3cc9029375ed54ed1f808dd9
  Author: Noah Goldstein <goldstein.w.n at gmail.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineAndOrXor.cpp

  Log Message:
  -----------
  [InstCombine] Rename some shadow variables; NFC

Reviewed By: RKSimon

Differential Revision: https://reviews.llvm.org/D159325


Compare: https://github.com/llvm/llvm-project/compare/377497f32ac9...2a904f456afa


More information about the All-commits mailing list