[all-commits] [llvm/llvm-project] 1b7a09: [Clang][AMDGPU] Permit language address spaces for...

[Joseph Huber via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 1b7a095e274d23065af8f576eb64ab26e4204c2b
      https://github.com/llvm/llvm-project/commit/1b7a095e274d23065af8f576eb64ab26e4204c2b
  Author: Joseph Huber <35342157+jhuber6 at users.noreply.github.com>
  Date:   2023-09-13 (Wed, 13 Sep 2023)

  Changed paths:
    M clang/lib/CodeGen/Targets/AMDGPU.cpp
    A clang/test/CodeGen/amdgpu-address-spaces.cpp

  Log Message:
  -----------
  [Clang][AMDGPU] Permit language address spaces for AMDGPU globals (#66205)

Summary:
Currently, there is an assertion that prevents us from emitting an
AMDGPU global with a non-target specific address space (i.e. numerical
attribute). I'm unsure what the original intentions of this assertion
were, but we should be able to use OpenCL address spaces when compiling
directly to AMDGPU from C++. This is permitted on NVPTX so I'm unsure
what this assertion is guarding. The patch simply removes the assertion
and adds a test to ensure that these emit the expected address spaces.

Fixes https://github.com/llvm/llvm-project/issues/65069