[all-commits] [llvm/llvm-project] f94b6f: [OpenMP] Remove optimization skipping reduction st...

[Rodrigo Ceccato de Freitas via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f94b6f3396ce8b2c1575a4c459c4881381f0d5b1
      https://github.com/llvm/llvm-project/commit/f94b6f3396ce8b2c1575a4c459c4881381f0d5b1
  Author: Rodrigo Ceccato de Freitas <29164832+rodrigo-ceccato at users.noreply.github.com>
  Date:   2023-09-12 (Tue, 12 Sep 2023)

  Changed paths:
    A openmp/libomptarget/test/offloading/task_in_reduction_target.c
    M openmp/runtime/src/kmp_tasking.cpp

  Log Message:
  -----------
  [OpenMP] Remove optimization skipping reduction struct initialization (#65697)

This commit removes an optimization that skips the initialization of the
reduction struct if the number of threads in a team is 1. This
optimization
caused a bug with Hidden Helper Threads. When the task group is
initially
initialized by the master thread but a Hidden Helper Thread executes a
target
nowait region, it requires the reduction struct initialization to
properly
accumulate the data.

This commit also adds a LIT test for issue #57522 to ensure that the
issue is
properly addressed and that the optimization removal does not introduce
any
regressions.

Fixes: #57522