[all-commits] [llvm/llvm-project] 42d556: [libc++abi] Overhaul test_exception_storage.pass.cpp

Shoaib Meenai via All-commits all-commits at lists.llvm.org
Mon Sep 11 11:15:01 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 42d55676833bacfdc6ec66785b74a7a51e6de474
      https://github.com/llvm/llvm-project/commit/42d55676833bacfdc6ec66785b74a7a51e6de474
  Author: Shoaib Meenai <smeenai at fb.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M libcxxabi/test/test_exception_storage.pass.cpp
    A libcxxabi/test/test_exception_storage.threads.pass.cpp

  Log Message:
  -----------
  [libc++abi] Overhaul test_exception_storage.pass.cpp

I'm making a change in this area (https://reviews.llvm.org/D138461), so update the test:
* Add proper synchronization instead of a sleep.
* Avoid some unnecessary size_t casts.
* Spawn the number of hardware threads instead of 10.
* Check that `__cxa_get_globals` and `__cxa_get_globals_fast` return
  the same values.
* Split the test in with-threads and without-threads tests to simplify
  the code.

Differential Revision: https://reviews.llvm.org/D138460

Co-authored-by: Louis Dionne <ldionne.2 at gmail.com>




More information about the All-commits mailing list