[all-commits] [llvm/llvm-project] 62bec3: [libcxx] Fix include directory order (#65859)

Alex Brachet via All-commits all-commits at lists.llvm.org
Mon Sep 11 09:36:20 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 62bec3de128d3dda3d400eaf20cfb3ac220e23d1
      https://github.com/llvm/llvm-project/commit/62bec3de128d3dda3d400eaf20cfb3ac220e23d1
  Author: Alex Brachet <abrachet at google.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M libcxx/include/CMakeLists.txt
    M libcxx/modules/CMakeLists.txt

  Log Message:
  -----------
  [libcxx] Fix include directory order (#65859)

It's important that the arch directory be included first so that
its header files which interpose on the default include dir
be included instead of the default ones. The clang driver [1] does
this when not building with -nostdinc, the libcxx build should
do the same.

We found this after https://reviews.llvm.org/D154282 when cross
compiling from non Linux to Linux. If the host machine was not
Linux, _LIBCPP_HAS_NO_TIME_ZONE_DATABASE would be defined in
the default include dir __config_site, while it was undefined
in the arch specific one causing build failures.




More information about the All-commits mailing list