[all-commits] [llvm/llvm-project] 3125bd: [lldb] Correctly invalidate unloaded image tokens ...

[David Spickett via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 3125bd4bc7367a05ddf5477793a1ee51cecc3046
      https://github.com/llvm/llvm-project/commit/3125bd4bc7367a05ddf5477793a1ee51cecc3046
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M lldb/source/Plugins/Platform/POSIX/PlatformPOSIX.cpp
    M lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp
    M lldb/source/Target/Process.cpp
    M lldb/test/API/functionalities/load_unload/TestLoadUnload.py

  Log Message:
  -----------
  [lldb] Correctly invalidate unloaded image tokens (#65945)

Some functions in Process were using LLDB_INVALID_ADDRESS instead of
LLDB_INVALID_TOKEN.

The only visible effect of this appears to be that "process unload
<tab>" would complete to 0 even after the image was unloaded. Since the
command is checking for LLDB_INVALID_TOKEN.

Everything else worked somehow. I've added a check to the existing load
unload tests anyway.

The tab completion cannot be checked as is, but when I make them more
strict in a later patch it will be tested.