[all-commits] [llvm/llvm-project] 53602e: [OpenMP][OMPT] Fix device identifier collision dur...

Michael Halkenhäuser via All-commits all-commits at lists.llvm.org
Mon Sep 11 03:11:57 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 53602e6193d98b1e814b76a27e99ef7e18c9769c
      https://github.com/llvm/llvm-project/commit/53602e6193d98b1e814b76a27e99ef7e18c9769c
  Author: Michael Halkenhäuser <MichaelGerald.Halkenhauser at amd.com>
  Date:   2023-09-11 (Mon, 11 Sep 2023)

  Changed paths:
    M openmp/libomptarget/include/omptargetplugin.h
    M openmp/libomptarget/include/rtl.h
    M openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.cpp
    M openmp/libomptarget/plugins-nextgen/common/PluginInterface/PluginInterface.h
    M openmp/libomptarget/src/device.cpp
    M openmp/libomptarget/src/rtl.cpp

  Log Message:
  -----------
  [OpenMP][OMPT] Fix device identifier collision during callbacks (#65595)

Fixes: https://github.com/llvm/llvm-project/issues/65104
When a user assigns devices to target regions it may happen that
different identifiers will map onto the same id within different
plugins. This will lead to situations where callbacks will become much
harder to read, as ambiguous identifiers are reported.

We fix this by collecting the index-offset upon general RTL
initialization. Which in turn, allows to calculate the unique,
user-observable device id.




More information about the All-commits mailing list