[all-commits] [llvm/llvm-project] 77596e: Revert D157750 "[Driver][CodeGen] Properly handle ...

Fangrui Song via All-commits all-commits at lists.llvm.org
Mon Aug 21 13:54:30 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 77596e6b167bf0a5efa790597d6b75ac5e685b55
      https://github.com/llvm/llvm-project/commit/77596e6b167bf0a5efa790597d6b75ac5e685b55
  Author: Fangrui Song <i at maskray.me>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M clang/include/clang/Basic/DiagnosticDriverKinds.td
    M clang/lib/Driver/ToolChains/Clang.cpp
    R clang/test/Driver/fsplit-machine-functions-with-cuda-nvptx.c
    M clang/test/Driver/fsplit-machine-functions.c
    M clang/test/Driver/fsplit-machine-functions2.c
    M llvm/include/llvm/IR/DiagnosticInfo.h
    M llvm/lib/CodeGen/MachineFunctionSplitter.cpp
    M llvm/lib/IR/DiagnosticInfo.cpp
    R llvm/test/CodeGen/Generic/Inputs/fsloader-mfs.afdo
    M llvm/test/CodeGen/Generic/machine-function-splitter.ll

  Log Message:
  -----------
  Revert D157750 "[Driver][CodeGen] Properly handle -fsplit-machine-functions for fatbinary compilation."

This reverts commit 317a0fe5bd7113c0ac9d30b2de58ca409e5ff754.
This reverts commit 30c4b97aec60895a6905816670f493cdd1d7c546.

See post-commit discussions on https://reviews.llvm.org/D157750 that
we should use a different mechanism to handle the error with --cuda-gpu-arch=

The IR/DiagnosticInfo.cpp, warn_drv_for_elf_only, codegne tests in
clang/test/Driver, and the following driver behavior (downgrading error
to warning) changes are undesired.
```
% clang --target=riscv64 -fsplit-machine-functions -c a.c
warning: -fsplit-machine-functions is not valid for riscv64 [-Wbackend-plugin]
```




More information about the All-commits mailing list