[all-commits] [llvm/llvm-project] 446abb: [lldb/crashlog] Fix python version requirement issue

Med Ismail Bennani via All-commits all-commits at lists.llvm.org
Mon Aug 21 13:53:53 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 446abb5125f76423232e5d4d3ed116cccfbd8b99
      https://github.com/llvm/llvm-project/commit/446abb5125f76423232e5d4d3ed116cccfbd8b99
  Author: Med Ismail Bennani <ismail at bennani.ma>
  Date:   2023-08-21 (Mon, 21 Aug 2023)

  Changed paths:
    M lldb/examples/python/crashlog.py

  Log Message:
  -----------
  [lldb/crashlog] Fix python version requirement issue

In 21a597c, we fixed a module loading issue by using the new
`argparse.BooleanOptionalAction`. However, this is only available
starting python 3.9 and causes test failures on bots that don't fulfill
this requirement.

To address that, this patch replaces the use of `BooleanOptionalAction`
by a pair of 2 opposite `store` actions pointing to the same destination
variable.

Differential Revision: https://reviews.llvm.org/D158452

Signed-off-by: Med Ismail Bennani <ismail at bennani.ma>




More information about the All-commits mailing list