[all-commits] [llvm/llvm-project] 604004: [mlir][vector] VectorToSCF: Omit redundant out-of-...

Matthias Springer via All-commits all-commits at lists.llvm.org
Fri Jul 14 00:57:41 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 6040044f2f076aef4f70f45d66aa014a5e5bd7d6
      https://github.com/llvm/llvm-project/commit/6040044f2f076aef4f70f45d66aa014a5e5bd7d6
  Author: Matthias Springer <me at m-sp.org>
  Date:   2023-07-14 (Fri, 14 Jul 2023)

  Changed paths:
    M mlir/lib/Dialect/Vector/Transforms/LowerVectorTransfer.cpp
    M mlir/test/Conversion/VectorToSCF/vector-to-scf.mlir
    M mlir/test/Dialect/Vector/vector-transfer-to-vector-load-store.mlir

  Log Message:
  -----------
  [mlir][vector] VectorToSCF: Omit redundant out-of-bounds check

There was a bug in `TransferWriteNonPermutationLowering`, a pattern that extends the permutation map of a TransferWriteOp with leading transfer dimensions of size ones. These newly added transfer dimensions are always in-bounds, because the starting point of any dimension is in-bounds. VectorToSCF inserts out-of-bounds checks based on the "in_bounds" attribute and dims that are marked as out-of-bounds but that are actually always in-bounds lead to unnecessary "scf.if" ops.

Differential Revision: https://reviews.llvm.org/D155196




More information about the All-commits mailing list