[all-commits] [llvm/llvm-project] 8b4a27: [clangd][NFC] Remove dead code

Mariya Podchishchaeva via All-commits all-commits at lists.llvm.org
Thu Jul 13 03:55:45 PDT 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 8b4a27f410ba42b2e19651ddafc60cd878d0963c
      https://github.com/llvm/llvm-project/commit/8b4a27f410ba42b2e19651ddafc60cd878d0963c
  Author: Mariya Podchishchaeva <mariya.podchishchaeva at intel.com>
  Date:   2023-07-13 (Thu, 13 Jul 2023)

  Changed paths:
    M clang-tools-extra/clangd/refactor/tweaks/ExtractVariable.cpp
    M clang-tools-extra/clangd/tool/ClangdMain.cpp

  Log Message:
  -----------
  [clangd][NFC] Remove dead code

refactor/tweaks/ExtractVariable.cpp:
Condition (!C++ && !ExprType) is never true because if ExprType was null
we would early-exit earlier.

tool/ClangdMain.cpp:
StaticIdx variable is not initialized before check, so checking it
doesn't make sense.

Found by static analyzer tool.

Reviewed By: sammccall

Differential Revision: https://reviews.llvm.org/D155164




More information about the All-commits mailing list