[all-commits] [llvm/llvm-project] e1cebe: [InstCombine] add tests for icmp-of-and-of-select-...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Mon Jan 30 13:19:15 PST 2023

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: e1cebe9ed12a46282fb6cc9fa9e172b04e5474ef
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2023-01-30 (Mon, 30 Jan 2023)

  Changed paths:
    M llvm/test/Transforms/InstCombine/icmp-select.ll

  Log Message:
  [InstCombine] add tests for icmp-of-and-of-select-of-constants; NFC

This overlaps with the tests proposed in D134064
and providing coverage for D133919, but it is
both limited in scope and more comprehensive
because there are many potential ways to transform
these kinds of patterns.

  Commit: 98855059674cf1b6b415f8c543f2a923771fed27
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2023-01-30 (Mon, 30 Jan 2023)

  Changed paths:
    M llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp
    M llvm/test/Transforms/InstCombine/icmp-select.ll

  Log Message:
  [InstCombine] reduce icmp_eq0-of-and-of-select-of-constants

This is the most basic patch to handle fixing issue #57666.

D133919 proposes to handle much more than this in a single patch,
but I've used 10 regression tests just to make sure this part is
doing what I expected and nothing more, and it already shows even
more potential TODO items.

The more general proofs from D133919 are correct, but I want to
enable this in smaller steps to reduce risk:

Differential Revision: https://reviews.llvm.org/D142847

Compare: https://github.com/llvm/llvm-project/compare/c9986f826398...98855059674c

More information about the All-commits mailing list