[all-commits] [llvm/llvm-project] 0b4224: [mlir][AsmPrinter] Gracefully handle empty symbol

Bruno Schmitt via All-commits all-commits at lists.llvm.org
Mon Jan 30 12:51:26 PST 2023


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0b4224011aecb98facd406dc68dacecff40109e8
      https://github.com/llvm/llvm-project/commit/0b4224011aecb98facd406dc68dacecff40109e8
  Author: Bruno Schmitt <bruno at oschmitt.com>
  Date:   2023-01-30 (Mon, 30 Jan 2023)

  Changed paths:
    M mlir/lib/IR/AsmPrinter.cpp

  Log Message:
  -----------
  [mlir][AsmPrinter] Gracefully handle empty symbol

The GenericOp printer should support malformed IR without crashing

GitHub issue #59529

Differential Revision: https://reviews.llvm.org/D142818


  Commit: c9986f8263980ce6bc9ef87d96d97911eaad547d
      https://github.com/llvm/llvm-project/commit/c9986f8263980ce6bc9ef87d96d97911eaad547d
  Author: Bruno Schmitt <bruno at oschmitt.com>
  Date:   2023-01-30 (Mon, 30 Jan 2023)

  Changed paths:
    M mlir/lib/Pass/PassRegistry.cpp
    M mlir/test/Pass/pipeline-parsing.mlir
    M mlir/test/python/pass_manager.py

  Log Message:
  -----------
  [mlir][Pass] Handle spaces in pipeline strings

An user might want to add extra spaces for better readability, e.g:
```
mypm = pm.PassManager.parse(f"""builtin.module(
    mypass1,
        func.func(mypass2,mypass3)
)""")
```
GitHub issue #59151

The parser was not taking into account the possibility of spaces after
`)`or `}`

Differential Revision: https://reviews.llvm.org/D142821


Compare: https://github.com/llvm/llvm-project/compare/d558a70abf26...c9986f826398


More information about the All-commits mailing list