[all-commits] [llvm/llvm-project] 462a31: [APFloat] Remove workaround for old clang.

Craig Topper via All-commits all-commits at lists.llvm.org
Fri Dec 23 10:47:45 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 462a31f5a5abb905869ea93cc49b096079b11aa4
      https://github.com/llvm/llvm-project/commit/462a31f5a5abb905869ea93cc49b096079b11aa4
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
    M llvm/include/llvm/ADT/APFloat.h

  Log Message:
  -----------
  [APFloat] Remove workaround for old clang.

The comment says this is for clang 3.3. Our build requirements
are clang 5.0 or newer so I think we can remove this.

Reviewed By: nikic, RKSimon

Differential Revision: https://reviews.llvm.org/D140613


  Commit: 08d1d74289f4cf74b9ebbb1c0d2bd4bf6eec0561
      https://github.com/llvm/llvm-project/commit/08d1d74289f4cf74b9ebbb1c0d2bd4bf6eec0561
  Author: Craig Topper <craig.topper at sifive.com>
  Date:   2022-12-23 (Fri, 23 Dec 2022)

  Changed paths:
    M llvm/include/llvm/ADT/APInt.h

  Log Message:
  -----------
  [APInt] Move a comment from urem to srem where it belongs.

This comment talks about sign of the dividend and the result. I
think it belongs to the srem function.

This is the commit that added it
https://github.com/llvm/llvm-project/commit/709a820a5338ca5c4b949f2f0286f7da39f00661
and the code change with it was for srem.

Reviewed By: nikic

Differential Revision: https://reviews.llvm.org/D140611


Compare: https://github.com/llvm/llvm-project/compare/aad725928d76...08d1d74289f4


More information about the All-commits mailing list