[all-commits] [llvm/llvm-project] 4dcfb0: [NFC][CodeGen] Use const MF in TargetLowering stac...

Josh Stone via All-commits all-commits at lists.llvm.org
Fri Sep 23 09:34:35 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4dcfb09e401dbe60e066f0da30b024b53630da31
      https://github.com/llvm/llvm-project/commit/4dcfb09e401dbe60e066f0da30b024b53630da31
  Author: Josh Stone <jistone at redhat.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M llvm/include/llvm/CodeGen/TargetLowering.h
    M llvm/lib/Target/PowerPC/PPCISelLowering.cpp
    M llvm/lib/Target/PowerPC/PPCISelLowering.h
    M llvm/lib/Target/SystemZ/SystemZISelLowering.cpp
    M llvm/lib/Target/SystemZ/SystemZISelLowering.h
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/lib/Target/X86/X86ISelLowering.h

  Log Message:
  -----------
  [NFC][CodeGen] Use const MF in TargetLowering stack probe functions

This makes them callable from places like canUseAsPrologue.

Differential Revision: https://reviews.llvm.org/D134492


  Commit: 26c37b461a02815ccd5d0b4300823542ceeed54e
      https://github.com/llvm/llvm-project/commit/26c37b461a02815ccd5d0b4300823542ceeed54e
  Author: Josh Stone <jistone at redhat.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M llvm/lib/Target/X86/X86FrameLowering.cpp
    A llvm/test/CodeGen/X86/probe-stack-eflags.ll

  Log Message:
  -----------
  [X86] Don't allow prologue stack probing with live EFLAGS

Fixes https://github.com/llvm/llvm-project/issues/49509

Differential Revision: https://reviews.llvm.org/D134494


  Commit: cb46ffdbf44c4c9097531091dca92acf54844150
      https://github.com/llvm/llvm-project/commit/cb46ffdbf44c4c9097531091dca92acf54844150
  Author: Josh Stone <jistone at redhat.com>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M llvm/lib/Target/X86/X86FrameLowering.cpp
    M llvm/test/CodeGen/X86/probe-stack-eflags.ll

  Log Message:
  -----------
  [X86] Use BuildStackAdjustment in stack probes

This has the advantage of dealing with live EFLAGS, using LEA instead of
SUB if needed to avoid clobbering. That also respects feature "lea-sp".

We could allow unrolled stack probing from blocks with live-EFLAGS, if
canUseAsEpilogue learns when emitStackProbeInlineGeneric will be used.

Differential Revision: https://reviews.llvm.org/D134495


Compare: https://github.com/llvm/llvm-project/compare/0de7c15c88b0...cb46ffdbf44c


More information about the All-commits mailing list