[all-commits] [llvm/llvm-project] c831ce: [LLDB] Fix "memory region --all" when there is no ...

David Spickett via All-commits all-commits at lists.llvm.org
Fri Sep 23 05:32:55 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: c831cea5efaaafaa97e3faf3119da3362868f41a
      https://github.com/llvm/llvm-project/commit/c831cea5efaaafaa97e3faf3119da3362868f41a
  Author: David Spickett <david.spickett at linaro.org>
  Date:   2022-09-23 (Fri, 23 Sep 2022)

  Changed paths:
    M lldb/source/Commands/CommandObjectMemory.cpp
    M lldb/test/API/functionalities/memory-region/TestMemoryRegion.py

  Log Message:
  -----------
  [LLDB] Fix "memory region --all" when there is no ABI plugin

There are two conditions for the loop exit. Either we hit LLDB_INVALID_ADDRESS
or the ABI tells us we are beyond mappable memory.

I made a mistake in that second part that meant if you had no ABI plugin
--all would stop on the first loop and return nothing.

If there's no ABI plugin we should only check for LLDB_INVALID_ADDRESS.

Depends on D134029

Reviewed By: labath

Differential Revision: https://reviews.llvm.org/D134030




More information about the All-commits mailing list