[all-commits] [llvm/llvm-project] 10409b: [FPEnv] Remove inaccurate comments regarding signa...

Yueh-Ting (eop) Chen via All-commits all-commits at lists.llvm.org
Thu Sep 22 18:13:31 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 10409bf86e58320443db5c5ea2adf5e437104ee9
      https://github.com/llvm/llvm-project/commit/10409bf86e58320443db5c5ea2adf5e437104ee9
  Author: eopXD <yueh.ting.chen at gmail.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M clang/lib/CodeGen/CGBuiltin.cpp

  Log Message:
  -----------
  [FPEnv] Remove inaccurate comments regarding signaling NaN for isless

By draft of C23 (https://www.open-std.org/jtc1/sc22/wg14/www/docs/n2912.pdf),
the description for isless macro under 7.12.17.3 says,

The isless macro determines whether its first argument is less than its second
argument. The value of isless(x,y) is always equal to (x)< (y); however, unlike
(x) < (y), isless(x,y) does not raise the invalid floating-point exception when
x and y are unordered and neither is a signaling NaN.

isless should trap when encountering signaling NaN.

Reviewed By: jcranmer-intel, efriedma

Differential Revision: https://reviews.llvm.org/D134407




More information about the All-commits mailing list