[all-commits] [llvm/llvm-project] 794b7e: Revert "[MemProf] Memprof profile matching and ann...

[Teresa Johnson via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 794b7ea960ccc3222f2af582efadbc5e5c464292
      https://github.com/llvm/llvm-project/commit/794b7ea960ccc3222f2af582efadbc5e5c464292
  Author: Teresa Johnson <tejohnson at google.com>
  Date:   2022-09-22 (Thu, 22 Sep 2022)

  Changed paths:
    M clang/lib/Frontend/CompilerInvocation.cpp
    R clang/test/CodeGen/Inputs/memprof.exe
    R clang/test/CodeGen/Inputs/memprof.memprofraw
    R clang/test/CodeGen/memprof.cpp
    M llvm/include/llvm/Analysis/MemoryBuiltins.h
    M llvm/include/llvm/ProfileData/InstrProfReader.h
    M llvm/lib/Analysis/MemoryBuiltins.cpp
    M llvm/lib/Transforms/Instrumentation/PGOInstrumentation.cpp
    R llvm/test/Transforms/PGOProfile/Inputs/memprof.exe
    R llvm/test/Transforms/PGOProfile/Inputs/memprof.memprofraw
    R llvm/test/Transforms/PGOProfile/Inputs/memprof_pgo.profraw
    R llvm/test/Transforms/PGOProfile/memprof.ll
    R llvm/test/Transforms/PGOProfile/memprofmissingfunc.ll

  Log Message:
  -----------
  Revert "[MemProf] Memprof profile matching and annotation"

This reverts commit a212d8da94d08e229aa8d65283e4b116310bba10, and follow
on fixes 0cd6763fa93159b84d70a5bb602c24996acaafaa,
e9ff53d42feac7fc157718523275619a8106f2f3, and
37c6a25e9ab230e5e21fa34e246d9fec55275df0.

After re-reading the documentation for hash_combine, I don't think this
is the appropriate hash function to use for computing the hash to use as
a stack id in the metadata, since it is not guaranteed to produce stable
values across executions. I have not hit this problem, but plan to
switch to using an MD5 hash. I am hitting an issue with one of the bots
(https://lab.llvm.org/buildbot/#/builders/171/builds/20732)
where the values produced are only the lower 32 bits of the expected
hash values, however, which I assume is related to the implementation of
hash_combine and hash_code.

I believe I fixed all of the other bot failures with the follow on fixes,
which I'll merge into the new version before reapplying.