[all-commits] [llvm/llvm-project] 006a75: [mlir][LLVMIR] Do not create pseudo debug file nam...

Min-Yih Hsu via All-commits all-commits at lists.llvm.org
Wed Sep 21 09:47:51 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 006a752a3c033950eb16db6b63574c309fa43241
      https://github.com/llvm/llvm-project/commit/006a752a3c033950eb16db6b63574c309fa43241
  Author: Min-Yih Hsu <minyihh at uci.edu>
  Date:   2022-09-21 (Wed, 21 Sep 2022)

  Changed paths:
    M mlir/lib/Target/LLVMIR/ConvertFromLLVMIR.cpp
    M mlir/test/Target/LLVMIR/Import/basic.ll

  Log Message:
  -----------
  [mlir][LLVMIR] Do not create pseudo debug file name using llvm::Instruction

Previously in mlir-translate, if debug info was absent in a
llvm::Instruction, we tried to create one using the name of its defined
value in a textual LLVM IR file as the (pseudo) debug file name.
However, in order to get that name, we need to call out to LLVM's
SlotTracker, which, surprisingly, took a lot of time. Judging from
the usefulness of such pseudo debug file name and the performance penalty
during translation, this patch simply use "imported-bitcode" as the
debug file name in these case. Eliminating the need of using (expensive)
LLVM value numbering.

Differential Revision: https://reviews.llvm.org/D134305




More information about the All-commits mailing list