[all-commits] [llvm/llvm-project] 60528c: [clangd] Return earlier when snippet is empty

[Tom Praschan via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 60528c690a4c334d2a3a2c22eb97af9e67d7a91d
      https://github.com/llvm/llvm-project/commit/60528c690a4c334d2a3a2c22eb97af9e67d7a91d
  Author: Tom Praschan <13141438+tom-anders at users.noreply.github.com>
  Date:   2022-09-21 (Wed, 21 Sep 2022)

  Changed paths:
    M clang-tools-extra/clangd/CodeComplete.cpp
    M clang-tools-extra/clangd/unittests/CodeCompleteTests.cpp

  Log Message:
  -----------
  [clangd] Return earlier when snippet is empty

Fixes github.com/clangd/clangd/issues/1216

If the Snippet string is empty, Snippet.front() would trigger a crash.
Move the Snippet->empty() check up a few lines to avoid this. Should not
break any existing behavior.

Differential Revision: https://reviews.llvm.org/D134137