[all-commits] [llvm/llvm-project] 78833a: [GlobalISel][Legalizer] Fix lowerSelect() not sign...

Amara Emerson via All-commits all-commits at lists.llvm.org
Tue Sep 20 08:40:57 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 78833a43e8d84e9650faa28ef8ee4517fbd7a11b
      https://github.com/llvm/llvm-project/commit/78833a43e8d84e9650faa28ef8ee4517fbd7a11b
  Author: Amara Emerson <amara at apple.com>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    M llvm/lib/CodeGen/GlobalISel/LegalizerHelper.cpp
    M llvm/test/CodeGen/AArch64/GlobalISel/legalize-select.mir

  Log Message:
  -----------
  [GlobalISel][Legalizer] Fix lowerSelect() not sign-extending the mask value.

I'm not sure why the SEXT_INREG was gated on a bitwidth check of the mask
vs element size.

This fixes a miscompile in chromium's skia library.

Differential Revision: https://reviews.llvm.org/D134236




More information about the All-commits mailing list