[all-commits] [llvm/llvm-project] 9b194f: [Sanitizer] Bump macOS deployment target for sanit...

thetruestblue via All-commits all-commits at lists.llvm.org
Tue Sep 20 03:44:48 PDT 2022

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 9b194fe2a2bd8e6e2ed43ef0b372f87bc939bba1
  Author: Blue Gaston <bgaston2 at apple.com>
  Date:   2022-09-20 (Tue, 20 Sep 2022)

  Changed paths:
    M compiler-rt/lib/sanitizer_common/tests/CMakeLists.txt

  Log Message:
  [Sanitizer] Bump macOS deployment target for sanitizer unit test binary to support C++17 requirements.

This patch fixes a test failure on Apple caused by changing standard to c++17.
sanitizer_allocator_test.cpp requires language features introducied in 10.13 for c++17.
After initial investigation, it was not clear how to add this flag to a single file:

Becuase of this, we have upped the min version of this test suite to 10.13, the min version necessary to support necessary language features.

We felt this was a better option than upping the min version of the product to support a single test.
We are raising deployment target for a single test suite, rather than the product.

Differential Revision: https://reviews.llvm.org/D134091


More information about the All-commits mailing list