[all-commits] [llvm/llvm-project] eda61f: [SelectOpti] Fix lifetime intrinsic bug

Sotiris Apostolakis via All-commits all-commits at lists.llvm.org
Tue Sep 13 12:15:18 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: eda61fb656ab9e7b38330a94031ae1aac90eae3a
      https://github.com/llvm/llvm-project/commit/eda61fb656ab9e7b38330a94031ae1aac90eae3a
  Author: Sotiris Apostolakis <apostolakis at google.com>
  Date:   2022-09-13 (Tue, 13 Sep 2022)

  Changed paths:
    M llvm/lib/CodeGen/SelectOptimize.cpp
    M llvm/test/CodeGen/X86/select-optimize.ll

  Log Message:
  -----------
  [SelectOpti] Fix lifetime intrinsic bug

When a select is converted to a branch and load instructions are sinked to the true/false blocks,
lifetime intrinsics (if present) could be made unsound if not moved.

This conservatively moves all lifetime intrinsics in a transformed BB to the end block to ensure
preserved lifetime semantics.

Reviewed By: davidxl

Differential Revision: https://reviews.llvm.org/D133777




More information about the All-commits mailing list