[all-commits] [llvm/llvm-project] 4e44c2: [ValueTracking][InstCombine] restrict FP min/max m...

Sanjay Patel via All-commits all-commits at lists.llvm.org
Thu Aug 25 13:52:57 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 4e44c22c97be99f7c3864fb9fc68b3295835d837
      https://github.com/llvm/llvm-project/commit/4e44c22c97be99f7c3864fb9fc68b3295835d837
  Author: Sanjay Patel <spatel at rotateright.com>
  Date:   2022-08-25 (Thu, 25 Aug 2022)

  Changed paths:
    M llvm/lib/Analysis/ValueTracking.cpp
    M llvm/test/Transforms/InstCombine/minmax-fp.ll
    M llvm/unittests/Analysis/ValueTrackingTest.cpp

  Log Message:
  -----------
  [ValueTracking][InstCombine] restrict FP min/max matching to avoid miscompile

This is a long-standing FIXME with a non-FMF test that exposes
the bug as shown in issue #57357.

It's possible that there's still a way to miscompile by
mis-identifying/mis-folding FP min/max patterns, but
this patch only exposes a couple of seemingly minor
regressions while preventing the broken transform.




More information about the All-commits mailing list