[all-commits] [llvm/llvm-project] 681b97: Remove TODO related to adding assert from Sparse T...

vmrajas via All-commits all-commits at lists.llvm.org
Thu Aug 25 13:48:11 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 681b97e5869d49b1e5163534811f370ba5ac0e40
      https://github.com/llvm/llvm-project/commit/681b97e5869d49b1e5163534811f370ba5ac0e40
  Author: Rajas Vanjape <vmrajas at google.com>
  Date:   2022-08-25 (Thu, 25 Aug 2022)

  Changed paths:
    M mlir/lib/Dialect/SparseTensor/Pipelines/SparseTensorPipelines.cpp

  Log Message:
  -----------
  Remove TODO related to adding assert from Sparse Tensor Pipeline code

Removing the TODO related to asserting that original `pm` is for ModuleOp.
The TODO is removed for following reasons:
1. There is no easy way to do this. We currently don't have this information stored in OpPassManager object.
2. There are currently no consumers of this information and storing this information with OpPassManager for a
   simple assert will be an overkill.

Reviewed By: aartbik

Differential Revision: https://reviews.llvm.org/D132699




More information about the All-commits mailing list