[all-commits] [llvm/llvm-project] d098e4: Revert "[RISCV][test] Update branch-relaxation.ll ...

[Piggy via All-commits]

  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: d098e45eed6b663ffd7d6cd06e1e16f85a781ee8
      https://github.com/llvm/llvm-project/commit/d098e45eed6b663ffd7d6cd06e1e16f85a781ee8
  Author: ZHU Zijia <piggynl at outlook.com>
  Date:   2022-08-25 (Thu, 25 Aug 2022)

  Changed paths:
    M llvm/test/CodeGen/RISCV/branch-relaxation.ll

  Log Message:
  -----------
  Revert "[RISCV][test] Update branch-relaxation.ll with update_llc_test_checks.py [NFC]"

This reverts commit c374789fba484af62a327a9337c7c9107461ee51.


  Commit: 395bda933f76097fee350544e05373838d7e698b
      https://github.com/llvm/llvm-project/commit/395bda933f76097fee350544e05373838d7e698b
  Author: ZHU Zijia <piggynl at outlook.com>
  Date:   2022-08-25 (Thu, 25 Aug 2022)

  Changed paths:
    M llvm/test/CodeGen/RISCV/branch-relaxation.ll

  Log Message:
  -----------
  [RISCV][test] Update branch-relaxation.ll with update_llc_test_checks.py [NFC]

Update `llvm/test/CodeGen/RISCV/branch-relaxation.ll` with
`update_llc_test_checks.py`, according to
https://reviews.llvm.org/D130560#3746417:

>>! In D130560#3746417, @luismarques wrote:
>>>! In D130560#3746379, @luismarques wrote:
>> The tests don't seem to have been properly updated with
>> `update_llc_test_checks.py`.
>> `llvm/test/CodeGen/RISCV/branch-relaxation.ll` contains RV64 RUN
>> lines but the corresponding CHECK lines are missing in
>> some functions.
>
> Looking more closely at this, I guess you tried to only include the
> `CHECK-RV64` and `CHECK-RV32` checks when relevant. That's a good
> instinct but I guess it goes a bit against how we normally use
> `update_llc_test_checks.py`. My understanding of the trade-off of
> using that tool is that the test updates are much easier, even if
> sometimes the CHECKs aren't as tight as something more tailormade.

Reviewed By: luismarques

Differential Revision: https://reviews.llvm.org/D132625


Compare: https://github.com/llvm/llvm-project/compare/af39e6f6fc90...395bda933f76