[all-commits] [llvm/llvm-project] 770685: [flang] [runtime] Fix build warnings if built with...

Martin Storsjö via All-commits all-commits at lists.llvm.org
Thu Aug 25 01:58:16 PDT 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 770685e24d3176a10093feac128fd75fac2e3f2c
      https://github.com/llvm/llvm-project/commit/770685e24d3176a10093feac128fd75fac2e3f2c
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-08-25 (Thu, 25 Aug 2022)

  Changed paths:
    M flang/runtime/file.cpp

  Log Message:
  -----------
  [flang] [runtime] Fix build warnings if built with mingw

Check whether `F_OK` et al are defined before redefining them; mingw
headers do define them, so check before providing the windows fallback
defines.

Also check `_WIN32` instead of `WIN32`; this is how it's consistently
done in the rest of llvm. (The former is a compiler builtin define,
while the latter isn't, but it's commonly set by e.g. build systems.)

Differential Revision: https://reviews.llvm.org/D132481


  Commit: af39e6f6fc905f3c067f022fb44136779d2f9c84
      https://github.com/llvm/llvm-project/commit/af39e6f6fc905f3c067f022fb44136779d2f9c84
  Author: Martin Storsjö <martin at martin.st>
  Date:   2022-08-25 (Thu, 25 Aug 2022)

  Changed paths:
    M lld/COFF/Driver.cpp
    A lld/test/COFF/includeoptional-export.s

  Log Message:
  -----------
  [LLD] [COFF] Fix export directives in object files from -includeoptional

When an object file contains an export directive, we normally do some
amount of deferred processing of them at the end of the linking
process. The -includeoptional option was handled after this, and
any object files (defining new exports) weren't handled.

Move the handling of the -includeoptional into the same late loop
which does the fixups for e.g. export directives.

Ideally, this would also be done for object files that are pulled
in by the wrap options, and for mingw autoimports, but those changes
require more modifications, to make them safe for potentially
being executed multiple times.

This fixes https://github.com/llvm/llvm-project/issues/57243.

Differential Revision: https://reviews.llvm.org/D132361


Compare: https://github.com/llvm/llvm-project/compare/c374789fba48...af39e6f6fc90


More information about the All-commits mailing list