[all-commits] [llvm/llvm-project] 5a7b91: [mlir][NFC] Rename StandardToLLVM to FuncToLLVM

River Riddle via All-commits all-commits at lists.llvm.org
Mon Mar 7 11:25:59 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 5a7b9194095b37f2274bd021753c3cd15e18eafa
      https://github.com/llvm/llvm-project/commit/5a7b9194095b37f2274bd021753c3cd15e18eafa
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M flang/lib/Optimizer/CodeGen/CodeGen.cpp
    M flang/tools/fir-opt/CMakeLists.txt
    M flang/tools/tco/CMakeLists.txt
    M mlir/docs/Dialects/Linalg/_index.md
    M mlir/docs/PassManagement.md
    M mlir/docs/Tutorials/Toy/Ch-6.md
    M mlir/examples/toy/Ch6/mlir/LowerToLLVM.cpp
    M mlir/examples/toy/Ch7/mlir/LowerToLLVM.cpp
    A mlir/include/mlir/Conversion/FuncToLLVM/ConvertFuncToLLVM.h
    A mlir/include/mlir/Conversion/FuncToLLVM/ConvertFuncToLLVMPass.h
    M mlir/include/mlir/Conversion/Passes.h
    M mlir/include/mlir/Conversion/Passes.td
    M mlir/include/mlir/Conversion/SPIRVToLLVM/SPIRVToLLVMPass.h
    R mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVM.h
    R mlir/include/mlir/Conversion/StandardToLLVM/ConvertStandardToLLVMPass.h
    M mlir/lib/Conversion/AsyncToLLVM/AsyncToLLVM.cpp
    M mlir/lib/Conversion/AsyncToLLVM/CMakeLists.txt
    M mlir/lib/Conversion/CMakeLists.txt
    A mlir/lib/Conversion/FuncToLLVM/CMakeLists.txt
    A mlir/lib/Conversion/FuncToLLVM/FuncToLLVM.cpp
    M mlir/lib/Conversion/GPUCommon/CMakeLists.txt
    M mlir/lib/Conversion/GPUCommon/GPUToLLVMConversion.cpp
    M mlir/lib/Conversion/GPUToNVVM/CMakeLists.txt
    M mlir/lib/Conversion/GPUToNVVM/LowerGpuOpsToNVVMOps.cpp
    M mlir/lib/Conversion/GPUToROCDL/CMakeLists.txt
    M mlir/lib/Conversion/GPUToROCDL/LowerGpuOpsToROCDLOps.cpp
    M mlir/lib/Conversion/OpenMPToLLVM/CMakeLists.txt
    M mlir/lib/Conversion/OpenMPToLLVM/OpenMPToLLVM.cpp
    M mlir/lib/Conversion/SPIRVToLLVM/CMakeLists.txt
    M mlir/lib/Conversion/SPIRVToLLVM/ConvertLaunchFuncToLLVMCalls.cpp
    R mlir/lib/Conversion/StandardToLLVM/CMakeLists.txt
    R mlir/lib/Conversion/StandardToLLVM/StandardToLLVM.cpp
    M mlir/lib/Conversion/VectorToROCDL/CMakeLists.txt
    M mlir/lib/Conversion/VectorToROCDL/VectorToROCDL.cpp
    M mlir/lib/Dialect/Linalg/Transforms/CMakeLists.txt
    M mlir/lib/Dialect/SparseTensor/Pipelines/SparseTensorPipelines.cpp
    M mlir/lib/ExecutionEngine/CMakeLists.txt
    M mlir/test/CAPI/execution_engine.c
    M mlir/test/Conversion/ComplexToLLVM/full-conversion.mlir
    M mlir/test/Conversion/ComplexToStandard/full-conversion.mlir
    A mlir/test/Conversion/FuncToLLVM/calling-convention.mlir
    A mlir/test/Conversion/FuncToLLVM/convert-argattrs.mlir
    A mlir/test/Conversion/FuncToLLVM/convert-data-layout.mlir
    A mlir/test/Conversion/FuncToLLVM/convert-funcs.mlir
    A mlir/test/Conversion/FuncToLLVM/convert-types.mlir
    A mlir/test/Conversion/FuncToLLVM/func-memref-return.mlir
    A mlir/test/Conversion/FuncToLLVM/func-memref.mlir
    A mlir/test/Conversion/FuncToLLVM/func-to-llvm.mlir
    A mlir/test/Conversion/FuncToLLVM/invalid.mlir
    R mlir/test/Conversion/StandardToLLVM/calling-convention.mlir
    R mlir/test/Conversion/StandardToLLVM/convert-argattrs.mlir
    R mlir/test/Conversion/StandardToLLVM/convert-data-layout.mlir
    R mlir/test/Conversion/StandardToLLVM/convert-funcs.mlir
    R mlir/test/Conversion/StandardToLLVM/convert-types.mlir
    R mlir/test/Conversion/StandardToLLVM/func-memref-return.mlir
    R mlir/test/Conversion/StandardToLLVM/func-memref.mlir
    R mlir/test/Conversion/StandardToLLVM/invalid.mlir
    R mlir/test/Conversion/StandardToLLVM/standard-to-llvm.mlir
    M mlir/test/Dialect/ArmSVE/legalize-for-llvm.mlir
    M mlir/test/Integration/Dialect/Async/CPU/microbench-linalg-async-parallel-for.mlir
    M mlir/test/Integration/Dialect/Async/CPU/microbench-scf-async-parallel-for.mlir
    M mlir/test/Integration/Dialect/Async/CPU/test-async-parallel-for-1d.mlir
    M mlir/test/Integration/Dialect/Async/CPU/test-async-parallel-for-2d.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/benchmark_matmul.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/matmul-vs-matvec.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/rank-reducing-subview.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-collapse-tensor.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-comprehensive-bufferize.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-1d-call.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-1d-nwc-wcf-call.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-2d-call.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-2d-nhwc-hwcf-call.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-3d-call.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-conv-3d-ndhwc-dhwcf-call.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-elementwise.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-expand-tensor.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-padtensor.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-subtensor-insert-multiple-uses.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-subtensor-insert.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-tensor-e2e.mlir
    M mlir/test/Integration/Dialect/Linalg/CPU/test-tensor-matmul.mlir
    M mlir/test/Integration/Dialect/Memref/memref_abi.c
    M mlir/test/Integration/Dialect/Standard/CPU/test-ceil-floor-pos-neg.mlir
    M mlir/test/Integration/Dialect/Standard/CPU/test_subview.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-mulf-full.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-mulf.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-muli-ext.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-muli-full.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-muli.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-tilezero-block.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/AMX/test-tilezero.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-dot.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-inline-asm-vector-avx512.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-mask-compress.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-rsqrt.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-sparse-dot-product.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-vp2intersect-i32.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-0-d-vectors.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-broadcast.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-compress.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-constant-mask.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-contraction.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-create-mask-v4i1.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-create-mask.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-expand.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-extract-strided-slice.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-flat-transpose-col.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-flat-transpose-row.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-fma.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-gather.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-index-vectors.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-insert-strided-slice.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-maskedload.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-maskedstore.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-matrix-multiply-col.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-matrix-multiply-row.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-outerproduct-f32.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-outerproduct-i64.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-print-int.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-reductions-f32-reassoc.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-reductions-f32.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-reductions-f64-reassoc.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-reductions-f64.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-reductions-i32.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-reductions-i4.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-reductions-i64.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-reductions-si4.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-reductions-ui4.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-scan.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-scatter.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-shape-cast.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-shuffle.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-sparse-dot-matvec.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-sparse-saxpy-jagged-matvec.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-1d.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-2d.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read-3d.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-read.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-to-loops.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transfer-write.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-transpose.mlir
    M mlir/test/Integration/Dialect/Vector/CPU/test-vector-distribute.mlir
    M mlir/test/Integration/GPU/CUDA/async.mlir
    M mlir/test/Target/LLVMIR/vector-to-llvm-ir.mlir
    M mlir/test/lib/Conversion/CMakeLists.txt
    A mlir/test/lib/Conversion/FuncToLLVM/CMakeLists.txt
    A mlir/test/lib/Conversion/FuncToLLVM/TestConvertCallOp.cpp
    R mlir/test/lib/Conversion/StandardToLLVM/CMakeLists.txt
    R mlir/test/lib/Conversion/StandardToLLVM/TestConvertCallOp.cpp
    M mlir/test/mlir-cpu-runner/X86Vector/math-polynomial-approx-avx2.mlir
    M mlir/test/mlir-cpu-runner/async-error.mlir
    M mlir/test/mlir-cpu-runner/async-group.mlir
    M mlir/test/mlir-cpu-runner/async-value.mlir
    M mlir/test/mlir-cpu-runner/async.mlir
    M mlir/test/mlir-cpu-runner/bare-ptr-call-conv.mlir
    M mlir/test/mlir-cpu-runner/copy.mlir
    M mlir/test/mlir-cpu-runner/global-memref.mlir
    M mlir/test/mlir-cpu-runner/math-polynomial-approx.mlir
    M mlir/test/mlir-cpu-runner/memref-reinterpret-cast.mlir
    M mlir/test/mlir-cpu-runner/memref-reshape.mlir
    M mlir/test/mlir-cpu-runner/sgemm-naive-codegen.mlir
    M mlir/test/mlir-cpu-runner/unranked-memref.mlir
    M mlir/test/mlir-cpu-runner/utils.mlir
    M mlir/test/mlir-opt/async.mlir
    M mlir/test/python/execution_engine.py
    M mlir/test/python/integration/dialects/linalg/opsrun.py
    M mlir/tools/mlir-opt/CMakeLists.txt
    M mlir/tools/mlir-spirv-cpu-runner/mlir-spirv-cpu-runner.cpp
    M mlir/tools/mlir-vulkan-runner/mlir-vulkan-runner.cpp
    M mlir/unittests/ExecutionEngine/Invoke.cpp

  Log Message:
  -----------
  [mlir][NFC] Rename StandardToLLVM to FuncToLLVM

The current StandardToLLVM conversion patterns only really handle
the Func dialect. The pass itself adds patterns for Arithmetic/CFToLLVM, but
those should be/will be split out in a followup. This commit focuses solely
on being an NFC rename.

Aside from the directory change, the pattern and pass creation API have been renamed:
 * populateStdToLLVMFuncOpConversionPattern -> populateFuncToLLVMFuncOpConversionPattern
 * populateStdToLLVMConversionPatterns -> populateFuncToLLVMConversionPatterns
 * createLowerToLLVMPass -> createConvertFuncToLLVMPass

Differential Revision: https://reviews.llvm.org/D120778


  Commit: b04c87cf08a5cf0e9c922b98bfaa0da3bb4530fd
      https://github.com/llvm/llvm-project/commit/b04c87cf08a5cf0e9c922b98bfaa0da3bb4530fd
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Bufferization/IR/BufferizableOpInterface.h
    M mlir/include/mlir/Dialect/GPU/GPUDialect.h
    M mlir/include/mlir/Transforms/InliningUtils.h

  Log Message:
  -----------
  [mlir][NFC] Drop a few dead forward declarations of FuncOp


  Commit: a0b4aaffac9d1206be67284ed6d17a9297225c06
      https://github.com/llvm/llvm-project/commit/a0b4aaffac9d1206be67284ed6d17a9297225c06
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2022-03-07 (Mon, 07 Mar 2022)

  Changed paths:
    M mlir/include/mlir/Dialect/Affine/Analysis/NestedMatcher.h

  Log Message:
  -----------
  [mlir][NFC] Remove FuncOp overload of NestedPattern::match

This method is redundant with the Operation* overload, and is an artifact of when
FuncOp wasn't an operation.


Compare: https://github.com/llvm/llvm-project/compare/2d01ac18df93...a0b4aaffac9d


More information about the All-commits mailing list