[all-commits] [llvm/llvm-project] f75475: [lld-macho][nfc] Avoid using absolute addresses in...

Jez Ng via All-commits all-commits at lists.llvm.org
Thu Mar 3 16:00:57 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: f7547558c9f1b27d2fbc282ddd78e051b238db17
      https://github.com/llvm/llvm-project/commit/f7547558c9f1b27d2fbc282ddd78e051b238db17
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M lld/test/MachO/cgprofile-icf.s

  Log Message:
  -----------
  [lld-macho][nfc] Avoid using absolute addresses in cgprofile-icf.s

If we fix https://github.com/llvm/llvm-project/issues/54184, the
`dyld_stub_binder` symbol will get included in every output dylib. This
would cause the addresses of the other symbols to shift, breaking the
test as it currently stands. Let's make the test more flexible.

Reviewed By: lgrey

Differential Revision: https://reviews.llvm.org/D120940


  Commit: 5c268743da5818bc279b27648e9fccc37b9bb7dd
      https://github.com/llvm/llvm-project/commit/5c268743da5818bc279b27648e9fccc37b9bb7dd
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M lld/test/MachO/bind-opcodes.s

  Log Message:
  -----------
  [lld-macho][nfc] Use %lld-watchos substitution in bind-opcodes.s

Previously, we were using a syslibroot that pointed to macos while
linking against arch arm64_32, which didn't really make sense. It isn't
currently an issue, but will be if we add the `-lSystem` as part of
dealing with https://github.com/llvm/llvm-project/issues/54184.


Compare: https://github.com/llvm/llvm-project/compare/3d4e83f17dbe...5c268743da58


More information about the All-commits mailing list