[all-commits] [llvm/llvm-project] dd2959: [LTO] Initialize canAutoHide() using canBeOmittedF...

Jez Ng via All-commits all-commits at lists.llvm.org
Thu Mar 3 16:04:31 PST 2022


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: dd29597e103cd13dd308fb68283fce9d3411f723
      https://github.com/llvm/llvm-project/commit/dd29597e103cd13dd308fb68283fce9d3411f723
  Author: Jez Ng <jezng at fb.com>
  Date:   2022-03-03 (Thu, 03 Mar 2022)

  Changed paths:
    M lld/test/MachO/lto-internalize-unnamed-addr.ll
    M llvm/lib/Analysis/ModuleSummaryAnalysis.cpp
    M llvm/lib/Transforms/IPO/FunctionImport.cpp
    M llvm/test/ThinLTO/X86/Inputs/linkonce_odr_unnamed_addr.ll
    M llvm/test/ThinLTO/X86/linkonce_odr_unnamed_addr.ll

  Log Message:
  -----------
  [LTO] Initialize canAutoHide() using canBeOmittedFromSymbolTable()

Per discussion on
https://reviews.llvm.org/D59709#inline-1148734, this seems like the
right course of action. `canBeOmittedFromSymbolTable()` subsumes and
generalizes the previous logic. In addition to handling `linkonce_odr`
`unnamed_addr` globals, we now also internalize `linkonce_odr` +
`local_unnamed_addr` constants.

Reviewed By: tejohnson

Differential Revision: https://reviews.llvm.org/D120173




More information about the All-commits mailing list