[all-commits] [llvm/llvm-project] 34e8fd: [clangd] Treat "null" optional fields as missing

kadir çetinkaya via All-commits all-commits at lists.llvm.org
Fri Feb 19 19:39:39 PST 2021


  Branch: refs/heads/release/12.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 34e8fd50391923ec4d81ec988376588885107071
      https://github.com/llvm/llvm-project/commit/34e8fd50391923ec4d81ec988376588885107071
  Author: Kadir Cetinkaya <kadircet at google.com>
  Date:   2021-02-19 (Fri, 19 Feb 2021)

  Changed paths:
    M clang-tools-extra/clangd/Protocol.cpp

  Log Message:
  -----------
  [clangd] Treat "null" optional fields as missing

Clangd currently throws away any protocol messages whenever an optional
field has an unexpected type. This patch changes the behaviour to treat
`null` fields as missing.

This enables clangd to be more tolerant against small violations to the
LSP spec.

Fixes https://github.com/clangd/vscode-clangd/issues/134

Differential Revision: https://reviews.llvm.org/D95229

(cherry picked from commit af20232b8e189335da571f48c2467b244b7fd772)




More information about the All-commits mailing list