[all-commits] [llvm/llvm-project] 0c2bb6: [Driver] Clean up some Separate form options

Fangrui Song via All-commits all-commits at lists.llvm.org
Wed Feb 17 13:50:01 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 0c2bb6b446c584ab8a8b1231a136f657fa070e47
      https://github.com/llvm/llvm-project/commit/0c2bb6b446c584ab8a8b1231a136f657fa070e47
  Author: Fangrui Song <i at maskray.me>
  Date:   2021-02-17 (Wed, 17 Feb 2021)

  Changed paths:
    M clang/include/clang/Driver/Options.td
    M clang/lib/Driver/Driver.cpp
    M clang/lib/Driver/ToolChains/Clang.cpp
    M clang/lib/Driver/ToolChains/CommonArgs.cpp
    M clang/test/Driver/clang_f_opts.c
    M clang/test/Driver/debug-comp-dir.S
    R clang/test/Driver/debug.c
    M clang/test/Driver/rewrite-map-files.c
    M clang/test/Driver/rewrite-map-in-diagnostics.c
    M clang/test/Driver/symbol-rewriter.c
    M clang/test/Driver/working-directory.c

  Log Message:
  -----------
  [Driver] Clean up some Separate form options

Drop the `Separate` form of `-fmodule-name X`, `-fprofile-remapping-file X`, and `-frewrite-map-file X`.
To the best of my knowledge they are not used. Their conventional Joined forms (`-fFOO=`) should be used instead.

`-fdebug-compilation-dir X` is used in several places, e.g.  chromium/infra/goma.
It is also advertised in http://blog.llvm.org/2019/11/deterministic-builds-with-clang-and-lld.html
So we keep it but make the EQ form canonical and the Separate form an alias.

Differential Revision: https://reviews.llvm.org/D96886




More information about the All-commits mailing list