[all-commits] [llvm/llvm-project] 328261: Define new/delete in libc++ when using libcxxrt

Dimitry Andric via All-commits all-commits at lists.llvm.org
Mon Feb 15 12:22:52 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 328261019f50a76b11fa625739cbf32ceb2ce2f7
      https://github.com/llvm/llvm-project/commit/328261019f50a76b11fa625739cbf32ceb2ce2f7
  Author: Dimitry Andric <dimitry at andric.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M libcxx/cmake/Modules/HandleLibCXXABI.cmake
    A libcxx/cmake/caches/FreeBSD.cmake

  Log Message:
  -----------
  Define new/delete in libc++ when using libcxxrt

Always turn on LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS, if libcxxrt is used
as the C++ ABI library, since libcxxrt does not provide the full set
ofnew and delete operators. In particular, the aligned versions of these
operators are completely missing. This primarily addresses builds on
FreeBSD, as this platform uses libcxxrt by default.

Also, attempt to provide a FreeBSD.cmake cache file, with hopefully sane
settings, partially copied from the Apple.cmake cache file. This needs
more work, probably some additions to ci build scripts (although I am
not aware of any 'official' FreeBSD build bots).

Reviewed By: ldionne, #libc

Differential Revision: https://reviews.llvm.org/D96720




More information about the All-commits mailing list