[all-commits] [llvm/llvm-project] 343ba9: [OpenMP][NFC] Pre-commit test changes regarding PR...

Johannes Doerfert via All-commits all-commits at lists.llvm.org
Mon Feb 15 11:58:53 PST 2021


  Branch: refs/heads/release/12.x
  Home:   https://github.com/llvm/llvm-project
  Commit: 343ba9730b7d2166b5ce61f770413782573ea224
      https://github.com/llvm/llvm-project/commit/343ba9730b7d2166b5ce61f770413782573ea224
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M clang/test/OpenMP/nvptx_unsupported_type_messages.cpp

  Log Message:
  -----------
  [OpenMP][NFC] Pre-commit test changes regarding PR48933

This will highlight the effective changes in subsequent commits.

Reviewed By: ABataev

Differential Revision: https://reviews.llvm.org/D95903

(cherry picked from commit 3b2f19d0bc2803697526191a8a607efa0b38f7e4)


  Commit: 3b9ea2dc8eeb3c3893213f57d532b32ef3619859
      https://github.com/llvm/llvm-project/commit/3b9ea2dc8eeb3c3893213f57d532b32ef3619859
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M clang/include/clang/Sema/Sema.h
    M clang/lib/Sema/Sema.cpp
    M clang/lib/Sema/SemaDecl.cpp
    M clang/lib/Sema/SemaExpr.cpp
    M clang/lib/Sema/SemaOpenMP.cpp
    M clang/test/OpenMP/nvptx_unsupported_type_messages.cpp

  Log Message:
  -----------
  [OpenMP] Attribute target diagnostics properly

Type errors in function declarations were not (always) diagnosed prior
to this patch. Furthermore, certain remarks did not get associated
properly which caused them to be emitted multiple times.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D95912

(cherry picked from commit f9286b434b764b366f1aad9249c04e7741ed5518)


  Commit: 0d14528f8082ba12e34f41cbf931a7e7425b694a
      https://github.com/llvm/llvm-project/commit/0d14528f8082ba12e34f41cbf931a7e7425b694a
  Author: Johannes Doerfert <johannes at jdoerfert.de>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M clang/lib/Sema/SemaDecl.cpp
    M clang/lib/Sema/SemaOpenMP.cpp
    M clang/test/OpenMP/nvptx_allocate_messages.cpp
    M clang/test/OpenMP/nvptx_target_exceptions_messages.cpp
    M clang/test/OpenMP/nvptx_unsupported_type_messages.cpp

  Log Message:
  -----------
  [OpenMP] Delay more diagnostics of potentially non-emitted code

Even code in target and declare target regions might not be emitted.
With this patch we delay more diagnostics and use laziness and linkage
to determine if a function is emitted (for the device). Note that we
still eagerly emit diagnostics for target regions, unfortunately, see
the TODO for the reason.

This hopefully fixes PR48933.

Reviewed By: JonChesterfield

Differential Revision: https://reviews.llvm.org/D95928

(cherry picked from commit 1dd66e6111a8247c6c7931143251c0cf1442b905)


Compare: https://github.com/llvm/llvm-project/compare/3fe28ce26a33...0d14528f8082


More information about the All-commits mailing list