[all-commits] [llvm/llvm-project] 94828a: [llvm-nm] Tidy up error messages

James Henderson via All-commits all-commits at lists.llvm.org
Mon Feb 15 05:57:58 PST 2021


  Branch: refs/heads/main
  Home:   https://github.com/llvm/llvm-project
  Commit: 94828afd0a178d00abec87143b48fe0d7c063198
      https://github.com/llvm/llvm-project/commit/94828afd0a178d00abec87143b48fe0d7c063198
  Author: James Henderson <james.henderson at sony.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    M llvm/test/Object/macho-invalid.test
    M llvm/test/Object/nm-archive.test
    M llvm/test/Object/nm-shared-object.test
    M llvm/test/Object/nm-tapi-invalids.test
    M llvm/test/tools/llvm-nm/dynamic.test
    M llvm/test/tools/llvm-nm/invalid-input.test
    M llvm/tools/llvm-nm/llvm-nm.cpp

  Log Message:
  -----------
  [llvm-nm] Tidy up error messages

This adds colons to separate the file name from the message, removes a
duplicate space, and removes a trailing full stop from some messages.
These help bring the error messages into line with other tools, as well
as making all llvm-nm message more self-consistent.

Differential Revision: https://reviews.llvm.org/D96601

Reviewed by: Higuoxing, rupprecht, MaskRay


  Commit: 37c89803d860c6dd954cda1480dae6917f006972
      https://github.com/llvm/llvm-project/commit/37c89803d860c6dd954cda1480dae6917f006972
  Author: James Henderson <james.henderson at sony.com>
  Date:   2021-02-15 (Mon, 15 Feb 2021)

  Changed paths:
    A llvm/test/tools/llvm-nm/X86/bitcode.test
    A llvm/test/tools/llvm-nm/defined-only.test
    A llvm/test/tools/llvm-nm/format-bsd.test
    A llvm/test/tools/llvm-nm/just-symbol-name.test
    A llvm/test/tools/llvm-nm/reverse-sort.test

  Log Message:
  -----------
  [llvm-nm][test] Add additional test coverage for llvm-nm options

Some of these options have a degree of incidental coverage, or are for
Mach-O only. This patch adds dedicated ELF (where applicable) coverage.

Differential Revision: https://reviews.llvm.org/D96602

Reviewed by: rupprecht, Higuoxing


Compare: https://github.com/llvm/llvm-project/compare/eefd620a2572...37c89803d860


More information about the All-commits mailing list