[all-commits] [llvm/llvm-project] 41bf33: Revert rGd43a264a5dd3 "Revert "[X86][SSE] Fold unp...

Simon Pilgrim via All-commits all-commits at lists.llvm.org
Mon Jan 11 03:34:13 PST 2021


  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 41bf338dd1e7f07c1e89f171ff6d53578f5125be
      https://github.com/llvm/llvm-project/commit/41bf338dd1e7f07c1e89f171ff6d53578f5125be
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-01-11 (Mon, 11 Jan 2021)

  Changed paths:
    M llvm/lib/Target/X86/X86ISelLowering.cpp
    M llvm/test/CodeGen/X86/horizontal-shuffle-2.ll

  Log Message:
  -----------
  Revert rGd43a264a5dd3 "Revert "[X86][SSE] Fold unpack(hop(),hop()) -> permute(hop())""

This reapplies commit rG80dee7965dffdfb866afa9d74f3a4a97453708b2.

[X86][SSE] Fold unpack(hop(),hop()) -> permute(hop())

UNPCKL/UNPCKH only uses one op from each hop, so we can merge the hops and then permute the result.

REAPPLIED with a fix for unary unpacks of HOP.


  Commit: 5963229266303d83b2e9de09bce7e063276e41d0
      https://github.com/llvm/llvm-project/commit/5963229266303d83b2e9de09bce7e063276e41d0
  Author: Simon Pilgrim <llvm-dev at redking.me.uk>
  Date:   2021-01-11 (Mon, 11 Jan 2021)

  Changed paths:
    M llvm/test/CodeGen/X86/horizontal-shuffle-2.ll
    A llvm/test/CodeGen/X86/horizontal-shuffle-3.ll

  Log Message:
  -----------
  [X86][SSE] Add missing SSE test coverage for permute(hop,hop) folds

Should help avoid bugs like reported in rG80dee7965dff


Compare: https://github.com/llvm/llvm-project/compare/c37f68a8885c...596322926630


More information about the All-commits mailing list