[all-commits] [llvm/llvm-project] ca47ac: [source maps] Fix remove, insert-after and replace

[walter erquinigo via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: ca47ac3d5f6f8483d330c96a63f1cd862e667856
      https://github.com/llvm/llvm-project/commit/ca47ac3d5f6f8483d330c96a63f1cd862e667856
  Author: Walter Erquinigo <waltermelon at fb.com>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M lldb/source/Interpreter/OptionValuePathMappings.cpp
    M lldb/test/API/functionalities/source-map/TestTargetSourceMap.py

  Log Message:
  -----------
  [source maps] Fix remove, insert-after and replace

Summary:
In this diff of mine D77186 I introduce a bug in the replace operation, where I was failing fast by mistake.
Besides, a similar problem existed in the insert-after operation, where it was failing fast.

Finally, the remove operation was wrong, as it was not using the indices provided by the users.

I fixed those issues and added some tests account for cases with multiple elements in these requests.

Reviewers: labath, clayborg

Reviewed By: labath

Subscribers: mgrang, lldb-commits

Tags: #lldb

Differential Revision: https://reviews.llvm.org/D77324