[all-commits] [llvm/llvm-project] e3bb36: [mlir][DeclarativeParser] Emit an error if a `:` f...

[River Riddle via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: e3bb36370d59ce1bf4c22d2258e830999d8e833d
      https://github.com/llvm/llvm-project/commit/e3bb36370d59ce1bf4c22d2258e830999d8e833d
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M mlir/include/mlir/Dialect/Affine/IR/AffineOpsBase.td
    M mlir/include/mlir/IR/OpBase.td
    M mlir/test/IR/attribute.mlir
    M mlir/test/lib/Dialect/Test/TestOps.td
    M mlir/test/mlir-tblgen/op-format-spec.td
    M mlir/tools/mlir-tblgen/OpFormatGen.cpp

  Log Message:
  -----------
  [mlir][DeclarativeParser] Emit an error if a `:` follows an attribute with a non-constant type.

Summary: The attribute grammar includes an optional trailing colon type, so for attributes without a constant buildable type this will generally lead to unexpected and undesired behavior. Given that, it's better to just error out on these cases.

Differential Revision: https://reviews.llvm.org/D77293