[all-commits] [llvm/llvm-project] 79afdf: [mlir] Change the default of `mlir-print-op-on-dia...

[River Riddle via All-commits]

  Branch: refs/heads/master
  Home:   https://github.com/llvm/llvm-project
  Commit: 79afdfab9a57f9ddbc59e9ea0a3ea86635791920
      https://github.com/llvm/llvm-project/commit/79afdfab9a57f9ddbc59e9ea0a3ea86635791920
  Author: River Riddle <riddleriver at gmail.com>
  Date:   2020-04-03 (Fri, 03 Apr 2020)

  Changed paths:
    M mlir/include/mlir/IR/MLIRContext.h
    M mlir/lib/IR/Diagnostics.cpp
    M mlir/lib/IR/MLIRContext.cpp
    M mlir/lib/IR/Operation.cpp
    M mlir/lib/Support/MlirOptMain.cpp
    M mlir/tools/mlir-translate/mlir-translate.cpp

  Log Message:
  -----------
  [mlir] Change the default of `mlir-print-op-on-diagnostic` to true

Summary: It is a very common user trap to think that the location printed along with the diagnostic is the same as the current operation that caused the error. This revision changes the behavior to always print the current operation, except for when diagnostics are being verified. This is achieved by moving the command line flags in IR/ to be options on the MLIRContext.

Differential Revision: https://reviews.llvm.org/D77095